-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack trace on worklet factory crash #5197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Oct 6, 2023
Is it possible to add tests for this feature? 🤔 |
I can try, but this could be hacky 💻 🟢 |
Unfortunately, after many attempts, an Example is the best I can do in this situation. 😢 @piaskowyk |
tomekzaw
reviewed
Oct 19, 2023
piaskowyk
approved these changes
Oct 20, 2023
tomekzaw
reviewed
Oct 20, 2023
tomekzaw
approved these changes
Oct 27, 2023
tomekzaw
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5165
Since a worklet factory doesn't have it's counterpart in source code, when it crashes we can get a useless stack trace. It can crash when a variable that doesn't exists is referenced - since it's pulled into the worklet's factory closure. This PR fixes the stack trace on such crashes.
Test plan
Snippet that forces the factory crash