Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests in NextExample #5124

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add e2e tests in NextExample #5124

merged 3 commits into from
Sep 25, 2023

Conversation

bartlomiejbloniarz
Copy link
Contributor

@bartlomiejbloniarz bartlomiejbloniarz commented Sep 22, 2023 •
edited
Loading

Summary

This PR adds e2e tests for web. Tests are implemented with cypress.

Test plan

Check if the test passes, then change the target width in test.js and check that the test doesn't pass. Execute yarn build to build NextExample and then run yarn e2e:headless to start tests.

@bartlomiejbloniarz bartlomiejbloniarz marked this pull request as ready for review September 25, 2023 09:22
piaskowyk
piaskowyk approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bartlomiejbloniarz bartlomiejbloniarz added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit b79a17c Sep 25, 2023
@bartlomiejbloniarz bartlomiejbloniarz deleted the @bartlomiejbloniarz/add-next-e2e branch September 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomiejbloniarz @piaskowyk