Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useSharedValue.mdx - Example with an object as a shared value #5037

Closed
wants to merge 1 commit into from

Conversation

cdehaan
Copy link

@cdehaan cdehaan commented Sep 5, 2023

Example of how to update a share value which is an object.

Summary

Just an addition to the documentation, add if you think it might be helpful. I got it wrong initially, and actually ChatGPT gave incorrect advice when I asked it.

Test plan

No test needed, I think, since it's documentation.

Example of how to update a share value which is an object.
@kacperkapusciak
Copy link
Member

Hi @cdehaan

Thanks for pointing this out!

I fixed the CI and simplify the idea/code a bit in #5071 so I'm going to close this PR

Cheers ✌️

github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2023
Added note about handling objects in shared values

Thanks to @cdehaan for pointing this out! 🎖️ 

Supersedes
#5037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants