Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SET] Fix transition restart #4947

Merged
merged 16 commits into from
Sep 22, 2023
Merged

[SET] Fix transition restart #4947

merged 16 commits into from
Sep 22, 2023

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Aug 21, 2023 •
edited
Loading

Summary

This PR fixes the issue with shared element transition restart. Previously, there was a chance of the app crashing or a needed component disappearing. The purpose of this PR is to prevent app crashes and ensure a proper end state for the transition.

Test plan

Run example TransitionRestart.tsx example - available in this PR

@piaskowyk piaskowyk marked this pull request as ready for review August 23, 2023 15:18
@piaskowyk piaskowyk requested review from tomekzaw and tjzel August 28, 2023 08:09
tjzel
tjzel requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all the changes but it seems ok. I'd like to improve code quality for some of the places that I mentioned.

src/reanimated2/layoutReanimation/sharedTransitions/ProgressTransitionManager.ts Outdated Show resolved Hide resolved
src/reanimated2/layoutReanimation/sharedTransitions/ProgressTransitionManager.ts Outdated Show resolved Hide resolved
src/reanimated2/layoutReanimation/sharedTransitions/ProgressTransitionManager.ts Show resolved Hide resolved
src/reanimated2/layoutReanimation/sharedTransitions/ProgressTransitionManager.ts Outdated Show resolved Hide resolved
src/reanimated2/layoutReanimation/animationsManager.ts Show resolved Hide resolved
apple/LayoutReanimation/REASharedTransitionManager.m Outdated Show resolved Hide resolved
apple/LayoutReanimation/REASharedTransitionManager.m Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java Outdated Show resolved Hide resolved
tjzel

This comment was marked as duplicate.

Sign in to view

kacperkapusciak
kacperkapusciak approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand anything from this PR so I've QA it instead

On main the app crashes when a Shared Transition is interrupted by the user or programmatically

With this PR applied the transition snaps to the final stage without crashing

lgtm :shipit:

tjzel
tjzel approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@piaskowyk piaskowyk added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 839efad Sep 22, 2023
@piaskowyk piaskowyk deleted the @piaskowyk/SET-stability-v1 branch September 22, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piaskowyk @kacperkapusciak @tjzel