Add version property to worklets for Reanimated plugin version verification #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed plugin version check moved cpp version check back to original file modified tests and plugin to be able to run tests
tomekzaw
requested changes
Apr 17, 2023
tomekzaw
requested changes
Apr 18, 2023
tomekzaw
approved these changes
Apr 18, 2023
tjzel
added a commit
that referenced
this pull request
Apr 18, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR is adding a commit missed in #4370 . ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…cation (software-mansion#4370) ## Summary This PR modifies the way we verify if there is no mismatch between versions of Reanimated and Reanimated Babel plugin (for eg. when metro cache was not reset). - Added `__version` prop to every worklet in DEV. - Added version checking in runtime. - Added global variable to ensure error for the mismatch is logged only once. - Removed old `checkPluginVersion.ts` and moved `checkCppVersion.ts` back to `checkVersion.ts`. - Changed plugin's code and jest tests accordingly. ## Test plan 0. Run `yarn jest`. 1. Make a DEV bundle to confirm `__version` prop appears on worklets. 2. Make a production to bundle to confirm it doesn't appear there. 3. Build ExampleApp and fiddle with `jsVersion.ts` to confirm that it's working.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR is adding a commit missed in software-mansion#4370 . ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the way we verify if there is no mismatch between versions of Reanimated and Reanimated Babel plugin (for eg. when metro cache was not reset).
__versionprop to every worklet in DEV.checkPluginVersion.tsand movedcheckCppVersion.tsback tocheckVersion.ts.Test plan
yarn jest.__versionprop appears on worklets.jsVersion.tsto confirm that it's working.