Unify example apps #4288
Merged
Unify example apps #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Mar 29, 2023
Merged
6 tasks
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Note: This is a huge PR, please review the commits one-by-one. ### Changes - Create app package that holds the common code for all example apps + add CI checks - Move all examples from Example, FabricExample and WebExample to app directory - Use `App.tsx` from app directory in Example, FabricExample and WebExample apps - Use `export default function` wherever possible - Use `NativeStackNavigationProp` type instead of `StackNavigationProp` in SET examples and remove dependency - Remove test, test-suite and e2e directories and Detox configuration - Regenerate Example app using `npx react-native@next ReanimatedExample --version 0.71.3 --skip-install` - Use autolinking instead of manual linking in Example app (Android & iOS) like in FabricExample - Use original TypeScript and ESLint configuration in Example and FabricExample apps - Move `react-native-reanimated-tests.tsx` from FabricExample to `__typetests__` (as in react-native repo) ### TODO - [ ] Check apps in release mode ### Next steps - [ ] Make example list hierarchical - [ ] WebExample takes too long to bundle - [ ] Don't return to home screen after fast refresh on web ## Test plan Check if Example, FabricExample and WebExample work properly.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR updates `yarn.lock` after merging software-mansion#4288 without changes from software-mansion#4301. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: This is a huge PR, please review the commits one-by-one.
Changes
App.tsxfrom app directory in Example, FabricExample and WebExample appsexport default functionwherever possibleNativeStackNavigationProptype instead ofStackNavigationPropin SET examples and remove dependencynpx react-native@next ReanimatedExample --version 0.71.3 --skip-installreact-native-reanimated-tests.tsxfrom FabricExample to__typetests__(as in react-native repo)TODO
Next steps
Test plan
Check if Example, FabricExample and WebExample work properly.