Add flashImmediateRunning flag to setupSetImmediate #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Mar 28, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…#4280) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary - fixes software-mansion#4168 The problem is caused by recursive `callMicrotasks` calls. Recursive calls appear when we have an event that trigger another event that calls `callMicrotasks` synchronously. In result, we call the same microtasks array multiple times. In some cases we get the wrong order of instructions and we end up with `runRequested` set on `true` without callbacks in the queue, so we never call `queueMicrotask` again. The idea of fix is to set flag that inform us, that we are inside `callMicrotasks` call, so we don't execute the same callbacks again ## Test plan - Created minimal repro using to `Animated.ScrollView` components. (one trigger another) - Tested on example from issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem is caused by recursive
callMicrotaskscalls.Recursive calls appear when we have an event that trigger another event that calls
callMicrotaskssynchronously.In result, we call the same microtasks array multiple times.
In some cases we get the wrong order of instructions and we end up with
runRequestedset ontruewithout callbacks in the queue, so we never callqueueMicrotaskagain.The idea of fix is to set flag that inform us, that we are inside
callMicrotaskscall, so we don't execute the same callbacks againTest plan
Animated.ScrollViewcomponents. (one trigger another)