Fix npm pack including plugin/node_modules.
#4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with node_modules exclusion
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary No more. ### Honorable mentions `[0-9][0-9]?[0-9]?(\.[0-9]*)?\s*kB` this part of the regexp matches any size in form of `0.0... kB` to `999.9... kB` (dot and numbers past it are optional). ## Test plan Build tarball and see `plugin/node_modules/` gone for good. Look at [this CI](https://github.com/software-mansion/react-native-reanimated/actions/runs/4501464136/jobs/7921934230) to see that it cancelled on packed `node_modules`. Look at [this CI](https://github.com/software-mansion/react-native-reanimated/actions/runs/4501540333/jobs/7922114582) to see that it cancelled on exceeding 1MB in tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No more.
Honorable mentions
[0-9][0-9]?[0-9]?(\.[0-9]*)?\s*kBthis part of the regexp matches any size in form of0.0... kBto999.9... kB(dot and numbers past it are optional).Test plan
Build tarball and see
plugin/node_modules/gone for good.Look at this CI to see that it cancelled on packed
node_modules.Look at this CI to see that it cancelled on exceeding 1MB in tarball.