Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy interface for Animated.FlatList to enable passing itemLayoutAnimation prop #4074

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Feb 20, 2023

Summary

Fixed #4056 by adding proxy interface to the inheritance chain. Also changing itemLayoutAnimation to be optional, since it is optional in source files.

Test plan

build & run InvertedFlatList in Example app
run yarn jest

@tjzel tjzel requested review from tomekzaw and piaskowyk February 20, 2023 14:12
@tjzel tjzel changed the title @tjzel/refactor flat list inheritance Add proxy interface for Animated.FlatList to enable passing itemLayoutAnimation prop Feb 20, 2023
@tjzel tjzel added this pull request to the merge queue Feb 20, 2023
Merged via the queue into main with commit 4e3da1d Feb 20, 2023
@tjzel tjzel deleted the @tjzel/refactor-flat-list-inheritance branch February 20, 2023 15:09
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
…tAnimation prop (software-mansion#4074)

## Summary

Fixed
[software-mansion#4056](software-mansion#4056)
by adding proxy interface to the inheritance chain. Also changing
`itemLayoutAnimation` to be optional, since it is optional in source
files.

## Test plan

build & run `InvertedFlatList` in `Example` app
run `yarn jest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reanimared.Flatlist itemLayoutAnimation prop doesn't exist typescript
3 participants