Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sourceMap typo in plugin.js #4054

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fixed sourceMap typo in plugin.js #4054

merged 1 commit into from
Feb 15, 2023

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Feb 15, 2023

Summary

Fixed a typo in plugin.js that would provide wrong identifier for sourceMap and lead to undefined behaviour on error red box.

Test plan

UI error throws from ExampleWorklet.

@tjzel tjzel requested a review from tomekzaw February 15, 2023 15:05
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR! 🥳

Tested on Example app with Hermes enabled

Before (Hermes) After (Hermes)
before_hermes after_hermes

@tjzel tjzel added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 0ea0e69 Feb 15, 2023
@tjzel tjzel deleted the @tjzel/fix-typo-in-plugin branch February 15, 2023 15:52
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
## Summary

Fixed a typo in `plugin.js` that would provide wrong identifier for
`sourceMap` and lead to undefined behaviour on error red box.

## Test plan

UI error throws from `ExampleWorklet`.

Co-authored-by: Tomasz Żelawski <tomasz.zelawski@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants