[Shared Element Transition] Animation restart #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Feb 16, 2023
android/src/main/java/com/swmansion/reanimated/layoutReanimation/Snapshot.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Feb 16, 2023
| @@ -53,7 +53,8 @@ export class SharedTransition implements ILayoutAnimationBuilder { | |||
| const keyToTargetValue = | |||
| 'target' + propName.charAt(0).toUpperCase() + propName.slice(1); | |||
| animations[propName] = withTiming(values[keyToTargetValue], { | |||
| duration: 1000, | |||
| // native screen transition takes around 500ms | |||
| duration: 500, | |||
There was a problem hiding this comment.
I think it's 350 ms to be exact (source) but 500 ms is okay as well
There was a problem hiding this comment.
I set 500 ms because, in my subjective opinion, the transition with a 500 ms duration looks much better than animation with a 350 ms duration, but like I said. This is my subjective opinion. I think we should allow for users to determine the default transition duration. We should do it in another PR.
tomekzaw
approved these changes
Feb 17, 2023
piaskowyk
added a commit
that referenced
this pull request
Feb 24, 2023
In #4043 I changed the restarting animation logic in `animationManager.ts`. Accidentally I removed restarting animation for the rest of the Layout Animations. Fortunately, I found a better way to handle restart animation for both LA and SET animations types.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This change allows restarting of animation in two cases: - when someone changes the current screen during transition animation - when an update of layout comes for shared view during the transition animation **Known limitation**: If the parent of shared view updates owns the layout during the shared transition it doesn't affect for shared view layout. This issue will be fixed in the future.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
In software-mansion#4043 I changed the restarting animation logic in `animationManager.ts`. Accidentally I removed restarting animation for the rest of the Layout Animations. Fortunately, I found a better way to handle restart animation for both LA and SET animations types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows restarting of animation in two cases:
Known limitation: If the parent of shared view updates owns the layout during the shared transition it doesn't affect for shared view layout. This issue will be fixed in the future.