[Shared Element Transition] Fix exiting animations on Android #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Feb 7, 2023
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Feb 7, 2023
android/src/main/java/com/swmansion/reanimated/layoutReanimation/SharedTransitionManager.java
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Feb 8, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…re-mansion#4038) ## Summary I shouldn't clear the layout animation config when the shared element transition doesn't start. Without this check, the exiting layout animation couldn't start because LayoutAnimationManager doesn't contain the view config. ## Test plan Run exiting layout animation on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I shouldn't clear the layout animation config when the shared element transition doesn't start. Without this check, the exiting layout animation couldn't start because LayoutAnimationManager doesn't contain the view config.
Test plan
Run exiting layout animation on Android.