Fix Fabric crash in NativeReanimatedModule::removeShadowNodeFromRegistry
#4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Feb 3, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…stry` (software-mansion#4020) ## Summary This PR fixes a Fabric crash in `NativeReanimatedModule::removeShadowNodeFromRegistry`. I don't know the exact root cause but I know how to fix it. First, I added missing `makeShareableShadowNodeWrapper` call. However, since only the view tag is required on the native side, there's no need to pass the whole ShadowNodeWrapper, so I simply grab the view tag from `this._viewTag` and pass it to the cleanup worklet via closure. ## Steps to reproduce the issue 1. Launch FabricExample on iOS 2. Open "forwardRef & useImperativeHandle" example 3. Increase animation duration to 3000 ms 4. Randomly click both buttons 5. Go to previous screen 6. Crash https://user-images.githubusercontent.com/20516055/216365412-edb406ad-6947-4cdf-94aa-5b82bd079fab.mp4 ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…stry` (software-mansion#4076) ## Summary Follow-up to software-mansion#4020. ## Test plan Check if Conditional demo from FabricExample works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a Fabric crash in
NativeReanimatedModule::removeShadowNodeFromRegistry. I don't know the exact root cause but I know how to fix it.First, I added missing
makeShareableShadowNodeWrappercall. However, since only the view tag is required on the native side, there's no need to pass the whole ShadowNodeWrapper, so I simply grab the view tag fromthis._viewTagand pass it to the cleanup worklet via closure.Steps to reproduce the issue
Nagranie.z.ekranu.2023-02-2.o.16.06.55.mp4
Test plan