Rewrite isAnimated function
#3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: @kmagiera
jwajgelt
approved these changes
Jan 16, 2023
piaskowyk
approved these changes
Jan 17, 2023
tomekzaw
added a commit
that referenced
this pull request
Jan 17, 2023
## Summary This PR provides a new better implementation of `isAnimated` utility function as the previous version was very poorly written. The old implementation holds a queue of props to be checked and thus needs to allocate and populate a new array on each call, whereas the new implementation uses recursion instead – however, in most of the real-world cases, it is never called recursively. Since `isAnimated` is used very frequently throughout the codebase, previously it took ~7% of total execution time. After the changes, it dropped down to ~3%. Co-authored-by: @kmagiera ## Test plan Just check if BokehExample works.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR provides a new better implementation of `isAnimated` utility function as the previous version was very poorly written. The old implementation holds a queue of props to be checked and thus needs to allocate and populate a new array on each call, whereas the new implementation uses recursion instead – however, in most of the real-world cases, it is never called recursively. Since `isAnimated` is used very frequently throughout the codebase, previously it took ~7% of total execution time. After the changes, it dropped down to ~3%. Co-authored-by: @kmagiera ## Test plan Just check if BokehExample works.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a new better implementation of
isAnimatedutility function as the previous version was very poorly written. The old implementation holds a queue of props to be checked and thus needs to allocate and populate a new array on each call, whereas the new implementation uses recursion instead – however, in most of the real-world cases, it is never called recursively. SinceisAnimatedis used very frequently throughout the codebase, previously it took ~7% of total execution time. After the changes, it dropped down to ~3%.Co-authored-by: @kmagiera
Test plan
Just check if BokehExample works.