-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sensor listener leak on Android #3900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Jan 3, 2023
will this fix be available in v2.13.1? or which package ver should I install to get this fix? |
@ashuvssut We will ship this fix in 2.14.0 and 3.0.0-rc.10 next week. |
piaskowyk
approved these changes
Jan 5, 2023
piaskowyk
pushed a commit
that referenced
this pull request
Jan 10, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes #3896 In the scenario presented in the issue every time the component was mounted two `ReanimatedSensor` were created: one was just initialized and the second one added to the hashmap. Then, when unregistering, only the second one was unregistered, the first one was kept registered. After some time the max limit of registered listeners is hit. ## Test plan ```js import * as React from 'react'; import { Text, View, StyleSheet } from 'react-native'; import Constants from 'expo-constants'; import { useAnimatedSensor, SensorType } from 'react-native-reanimated'; export function BasicLayoutAnimation() { return ( <View style={styles.container}> <Parent /> </View> ); } const Parent = () => { const [state, setState] = React.useState(0); React.useEffect(() => { setInterval(() => setState((prevState) => ++prevState), 100); }, []); return ( <View style={[styles.container, styles.parent]}> <Text>Parent</Text> <Child /> </View> ); }; const Child = () => { useAnimatedSensor(SensorType.MAGNETIC_FIELD, { interval: 2000, }); const count = React.useRef(0); React.useEffect(() => { console.log('render count: ', ++count.current); }); return ( <View style={styles.container}> <Text>Child render: {count.current}</Text> </View> ); }; const styles = StyleSheet.create({ container: { flex: 1, justifyContent: 'center', paddingTop: Constants.statusBarHeight, backgroundColor: '#ecf0f1', padding: 20, }, parent: { backgroundColor: 'red', }, }); ```
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes software-mansion#3896 In the scenario presented in the issue every time the component was mounted two `ReanimatedSensor` were created: one was just initialized and the second one added to the hashmap. Then, when unregistering, only the second one was unregistered, the first one was kept registered. After some time the max limit of registered listeners is hit. ## Test plan ```js import * as React from 'react'; import { Text, View, StyleSheet } from 'react-native'; import Constants from 'expo-constants'; import { useAnimatedSensor, SensorType } from 'react-native-reanimated'; export function BasicLayoutAnimation() { return ( <View style={styles.container}> <Parent /> </View> ); } const Parent = () => { const [state, setState] = React.useState(0); React.useEffect(() => { setInterval(() => setState((prevState) => ++prevState), 100); }, []); return ( <View style={[styles.container, styles.parent]}> <Text>Parent</Text> <Child /> </View> ); }; const Child = () => { useAnimatedSensor(SensorType.MAGNETIC_FIELD, { interval: 2000, }); const count = React.useRef(0); React.useEffect(() => { console.log('render count: ', ++count.current); }); return ( <View style={styles.container}> <Text>Child render: {count.current}</Text> </View> ); }; const styles = StyleSheet.create({ container: { flex: 1, justifyContent: 'center', paddingTop: Constants.statusBarHeight, backgroundColor: '#ecf0f1', padding: 20, }, parent: { backgroundColor: 'red', }, }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3896
In the scenario presented in the issue every time the component was mounted two
ReanimatedSensor
were created: one was just initialized and the second one added to the hashmap. Then, when unregistering, only the second one was unregistered, the first one was kept registered. After some time the max limit of registered listeners is hit.Test plan