Fix unnecessary calls startMapper/stopMapper in useAnimatedReaction #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Mar 30, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…oftware-mansion#3864) ## Summary Hey! If we do not specify an array of dependencies in useAnimatedReaction and prepare or react has external dependent values (._closure), then the startMapper and stopMapper methods will be called an extra time on each render, even if the external values have not changed. ## Test plan If the functional component has such a block of code, then useEffect is called inside useAnimatedReaction on every render before these changes. ``` const value = 1; useAnimatedReaction( () => value, () => {}, ); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey!
If we do not specify an array of dependencies in useAnimatedReaction and prepare or react has external dependent values (._closure), then the startMapper and stopMapper methods will be called an extra time on each render, even if the external values have not changed.
Test plan
If the functional component has such a block of code, then useEffect is called inside useAnimatedReaction on every render before these changes.