Use weak object for shareables on V8 #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Dec 8, 2022
piaskowyk
approved these changes
Dec 8, 2022
kmagiera
pushed a commit
that referenced
this pull request
Dec 13, 2022
## Summary This PR enables weak object implementation for shareables when using V8 runtime. As @Kudo mentioned in #3722 (comment), react-native-v8 exposes weak objects API via JSI (see [here](https://github.com/Kudo/react-native-v8/blob/96a1a2c8a35349967a3ad7219106a3475b85433a/src/v8runtime/V8Runtime.cpp#L982-L997)). ## Test plan Run Example app with react-native-v8 and check if everything works.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR enables weak object implementation for shareables when using V8 runtime. As @Kudo mentioned in software-mansion#3722 (comment), react-native-v8 exposes weak objects API via JSI (see [here](https://github.com/Kudo/react-native-v8/blob/96a1a2c8a35349967a3ad7219106a3475b85433a/src/v8runtime/V8Runtime.cpp#L982-L997)). ## Test plan Run Example app with react-native-v8 and check if everything works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables weak object implementation for shareables when using V8 runtime.
As @Kudo mentioned in #3722 (comment), react-native-v8 exposes weak objects API via JSI (see here).
Test plan
Run Example app with react-native-v8 and check if everything works.