Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GestureHandlerRootView in WorkletExample #3829

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Dec 1, 2022

Summary

This PR adds <GestureHandlerRootView> in WorkletExample that are not necessary unless you paste the demo directly to App.tsx and lose 30 minutes of your life trying to figure out what's wrong.

Test plan

  1. Launch FabricExample
  2. Check if WorkletExample works

@tomekzaw tomekzaw requested a review from piaskowyk December 1, 2022 14:26
@piaskowyk piaskowyk merged commit e1e22bf into main Dec 15, 2022
@piaskowyk piaskowyk deleted the @tomekzaw/add-extra-root-view branch December 15, 2022 16:17
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
## Summary

This PR adds `<GestureHandlerRootView>` in `WorkletExample` that are not necessary unless you paste the demo directly to `App.tsx` and lose 30 minutes of your life trying to figure out what's wrong.

## Test plan

1. Launch FabricExample
2. Check if WorkletExample works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants