Checks for Reanimated2 #3692
Merged
Checks for Reanimated2 #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Oct 18, 2022
tomekzaw
reviewed
Oct 18, 2022
kkhabour
approved these changes
Oct 19, 2022
tomekzaw
approved these changes
Oct 20, 2022
piaskowyk
added a commit
that referenced
this pull request
Oct 20, 2022
## Description We need to add path `"src/reactNativeVersionPatch/messageQueueThread"` to source set only if Reanimated version is greater than 2. It broke the build on the Reanimated2 branch. I added also missed changes from #3566
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description We need to add path `"src/reactNativeVersionPatch/messageQueueThread"` to source set only if Reanimated version is greater than 2. It broke the build on the Reanimated2 branch. I added also missed changes from software-mansion#3566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to add path
"src/reactNativeVersionPatch/messageQueueThread"to source set only if Reanimated version is greater than 2. It broke the build on the Reanimated2 branch.I added also missed changes from #3566