Fix Example app with JSC on Android #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we use reanimated 2 without Hermes without this patch, or is this allowing it ? |
|
Hi @billouboq, we have just discovered this issue and haven't had time to investigate it so at this time I cannot answer your question, but feel free to try running Reanimated 2 without Hermes and let us know if it works! |
|
I've investigated the issue @billouboq, and it seems that it is only an issue with our Example app, so you should be fine using other runtimes than Hermes with Reanimated. |
|
Thanks you very much, will try it too ! |
This comment was marked as outdated.
This comment was marked as outdated.
tomekzaw
approved these changes
Sep 22, 2022
piaskowyk
approved these changes
Sep 29, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 6, 2022
## Description The Example app crashes on Android if compiled with JSC instead of Hermes. Error message: ``` 2022-09-15 12:34:45.701 15509-15509/com.swmansion.reanimated.example W/System.err: java.lang.UnsatisfiedLinkError: dlopen failed: library "libjsc.so" not found: needed by /data/app/~~YZvjm8gAMg_2TYxNnYOCDA==/com.swmansion.reanimated.example--9SU_U_zrfiGBnf1eSq-kA==/lib/arm64/libjscexecutor.so in namespace classloader-namespace ``` ## Cause of crash The `build.gradle` files in the Example app were outdated, which caused multiple issues. Some of the changes are: - Added missing 64-bit architectures in some places - Fixed enabled build abi resolution - Fixed incorrect maven repositories definition in top-level `build.gradle` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [x] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description The Example app crashes on Android if compiled with JSC instead of Hermes. Error message: ``` 2022-09-15 12:34:45.701 15509-15509/com.swmansion.reanimated.example W/System.err: java.lang.UnsatisfiedLinkError: dlopen failed: library "libjsc.so" not found: needed by /data/app/~~YZvjm8gAMg_2TYxNnYOCDA==/com.swmansion.reanimated.example--9SU_U_zrfiGBnf1eSq-kA==/lib/arm64/libjscexecutor.so in namespace classloader-namespace ``` ## Cause of crash The `build.gradle` files in the Example app were outdated, which caused multiple issues. Some of the changes are: - Added missing 64-bit architectures in some places - Fixed enabled build abi resolution - Fixed incorrect maven repositories definition in top-level `build.gradle` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Example app crashes on Android if compiled with JSC instead of Hermes. Error message:
Cause of crash
The
build.gradlefiles in the Example app were outdated, which caused multiple issues. Some of the changes are:build.gradleChecklist