Skip to content

Commit

Permalink
chore: Make GitHub actions names match their titles, cleanup (#6391)
Browse files Browse the repository at this point in the history
## Summary

Currently, the name of the (failing) GitHub action mismatches its
filename, which is annoying in development. This PR adds such matching
along with some necessary cleanups.

## Test plan

🚀
  • Loading branch information
tjzel authored Aug 12, 2024
1 parent 2436d3a commit 9d9ada4
Show file tree
Hide file tree
Showing 45 changed files with 436 additions and 578 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test V8 on Android nightly
name: V8 Reanimated build check [Nightly]
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
on:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Validate plugin
name: Babel plugin static check
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
Expand Down Expand Up @@ -35,10 +35,7 @@ jobs:

- name: Install monorepo dependencies
run: yarn install --immutable
- name: Install Reanimated node dependencies
working-directory: packages/react-native-reanimated
run: yarn install
- name: Build package
- name: Build Reanimated
working-directory: packages/react-native-reanimated
run: yarn build

Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/build-monorepo-nightly.yml

This file was deleted.

10 changes: 0 additions & 10 deletions .github/workflows/build-release-npm-package-rea3.yml

This file was deleted.

104 changes: 0 additions & 104 deletions .github/workflows/check-expo-dev-client-nightly.yml

This file was deleted.

90 changes: 0 additions & 90 deletions .github/workflows/check-react-native-nightly.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test docs build
name: Docs Reanimated build check
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish Reanimated Docs
name: Docs Reanimated publish
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test Android build
name: Example Android build check
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
Expand Down Expand Up @@ -41,36 +41,27 @@ jobs:
- name: Check out Git repository
uses: actions/checkout@v4

- name: Install dependencies in root
run: yarn install --immutable

- name: Setup Java 17
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: 17

- name: Restore Reanimated node_modules from cache
# TODO: Rework caching in this CI for monorepo setup.
- name: Restore node_modules from cache
uses: actions/cache@v3
with:
path: packages/react-native-reanimated/node_modules
key: ${{ runner.os }}-android-node-modules-reanimated-${{ hashFiles('packages/react-native-reanimated/yarn.lock') }}
restore-keys: ${{ runner.os }}-android-node-modules-reanimated-

- name: Install Reanimated node_modules
working-directory: packages/react-native-reanimated
run: yarn install --immutable

path: .
key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
restore-keys: ${{ runner.os }}-node-modules-
- name: Restore app node_modules from cache
uses: actions/cache@v3
with:
path: ${{ matrix.working-directory }}/node_modules
key: ${{ runner.os }}-android-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
restore-keys: ${{ runner.os }}-android-node-modules-${{ matrix.working-directory }}-

- name: Install app node_modules
working-directory: ${{ matrix.working-directory }}
run: yarn install
key: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
restore-keys: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-
- name: Install monorepo node dependencies
run: yarn install --immutable

- name: Build app
working-directory: ${{ matrix.working-directory }}/android
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test iOS build
name: Example iOS build check
env:
YARN_ENABLE_HARDENED_MODE: 0
on:
Expand Down Expand Up @@ -45,29 +45,21 @@ jobs:
- name: Check out Git repository
uses: actions/checkout@v4

- name: Install monorepo node dependencies
run: yarn install
- name: Restore Reanimated node_modules from cache
# TODO: Rework caching in this CI for monorepo setup.
- name: Restore node_modules from cache
uses: actions/cache@v3
with:
path: packages/react-native-reanimated/node_modules
key: ${{ runner.os }}-node-modules-reanimated-${{ hashFiles('packages/react-native-reanimated/yarn.lock') }}
restore-keys: ${{ runner.os }}-node-modules-reanimated-

- name: Install Reanimated node dependencies
working-directory: packages/react-native-reanimated
run: yarn install

path: .
key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
restore-keys: ${{ runner.os }}-node-modules-
- name: Restore app node_modules from cache
uses: actions/cache@v3
with:
path: ${{ matrix.working-directory }}/node_modules
key: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-${{ hashFiles(format('{0}/yarn.lock', matrix.working-directory)) }}
restore-keys: ${{ runner.os }}-node-modules-${{ matrix.working-directory }}-

- name: Install app node_modules
working-directory: ${{ matrix.working-directory }}
run: yarn install
- name: Install monorepo node dependencies
run: yarn install --immutable

- name: Restore Pods from cache
uses: actions/cache@v3
Expand All @@ -81,8 +73,8 @@ jobs:
- name: Install Pods
working-directory: ${{ matrix.working-directory }}/ios
run: |
bundler install
bundler exec pod install
bundle install
bundle exec pod install
- name: Restore build artifacts from cache
uses: actions/cache@v3
Expand Down
Loading

0 comments on commit 9d9ada4

Please sign in to comment.