Add react-native-svg interface
#3242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native-svg for improved hit detection of svg elementsreact-native-svg to improve hit-boxes of svg elements
react-native-svg to improve hit-boxes of svg elementsreact-native-svg interface
4 tasks
|
Integration works as of bd51ac7, but I have to test it a bit more before it's ready. |
jakex7
pushed a commit
to software-mansion/react-native-svg
that referenced
this pull request
Nov 28, 2024
…interface (#2555) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect --> # Summary Adding an `RNGH <-> RNSVG` interface requires usage of `RenderableView.hitTest` to work. ([link](software-mansion/react-native-gesture-handler#3242)) Currently, `RenderableView.hitTest` is `package-private`, meaning it cannot be accessed by other packages. This change does not change any functionality of the library, it only exposes existing functions to other libraries. I only made public those `hitTest` implementation which are strictly necessary for this interface, this is why multiple, if not most `hitTest` implementations remain `package-private` despite the changes made in the PR. ## Test Plan - open the example app, see how the app builds successfully ### What's required for testing (prerequisites)? - `RNSVG`'s `paper-example` app ### What are the steps to reproduce (after prerequisites)? ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ❌ | | MacOS | ❌ | | Android | ✅ | | Web | ❌ | ## Checklist <!-- Check completed item, when applicable, via: [X] --> - [X] I have tested this on a device and a simulator - [ ] I added documentation in `README.md` - [ ] ~~I updated the typed files (typescript)~~ - [ ] I added a test for the API in the `__tests__` folder
…tware-mansion/react-native-gesture-handler into @latekvo/add-svg-integration
4 tasks
Will remove this comment, and replace the minimal version check with the latest version, as soon as this PR is released. |
m-bert
reviewed
Jan 8, 2025
android/nosvg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Outdated
Show resolved
Hide resolved
android/svg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Outdated
Show resolved
Hide resolved
android/svg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Outdated
Show resolved
Hide resolved
android/svg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Outdated
Show resolved
Hide resolved
jakex7
reviewed
Jan 14, 2025
android/svg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Show resolved
Hide resolved
android/nosvg/src/main/java/com/swmansion/gesturehandler/RNSVGHitTester.kt
Outdated
Show resolved
Hide resolved
m-bert
approved these changes
Jan 14, 2025
jakex7
pushed a commit
to software-mansion/react-native-svg
that referenced
this pull request
Jan 15, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect --> # Summary This PR reverts #2555, as `RenderableView.hitTest()` can be replaced by `SvgView.reactTagForTouch()`, which is already `public`. This PR also changes the `package-private` `getSvgView()` method of `VirtualView` to `public`. This change has been made to handle hit detection of transformed `VirtualView`s, as `RenderableView`'s `hitTest()` doesn't take transformations into account, while `SvgView`'s `reactTagForTouch()` does. Making `getSvgView()` public is necessary for integrating RNSVG support into RNGH. More details [here](software-mansion/react-native-gesture-handler#3242). ## Test Plan Run the example from the RNGH - RNSVG [integration PR](software-mansion/react-native-gesture-handler#3242). ## Compatibility | OS | Implemented | | ------- | :---------: | | Android | ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration with the
react-native-svg(RNSVG) to improve hitbox detection of the SVG elements they provide.blocked by software-mansion/react-native-svg#2583
blocked by
nested SvgViews with viewBox prop have invalid hit detection- No issue opened yetTest plan