-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple statements in single line evaluation #17
Merged
bors
merged 1 commit into
softdevteam:main
from
Pavel-Durov:semicolumn-separated-statements
Mar 16, 2023
Merged
multiple statements in single line evaluation #17
bors
merged 1 commit into
softdevteam:main
from
Pavel-Durov:semicolumn-separated-statements
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel-Durov
changed the title
single line program with multiple statements eval
multiple statements evaluation
Mar 13, 2023
Pavel-Durov
force-pushed
the
semicolumn-separated-statements
branch
from
March 14, 2023 17:42
09e9e57
to
c8204f5
Compare
Pavel-Durov
changed the title
multiple statements evaluation
DRAFT - WIP - multiple statements evaluation
Mar 14, 2023
Pavel-Durov
force-pushed
the
semicolumn-separated-statements
branch
from
March 15, 2023 09:34
c8204f5
to
fee4f6d
Compare
Pavel-Durov
changed the title
DRAFT - WIP - multiple statements evaluation
multiple statements evaluation
Mar 15, 2023
bors try |
Pavel-Durov
changed the title
multiple statements evaluation
multiple statements in single line evaluation
Mar 15, 2023
Pavel-Durov
force-pushed
the
semicolumn-separated-statements
branch
from
March 15, 2023 09:36
fee4f6d
to
c7954b7
Compare
tryBuild succeeded: |
vext01
reviewed
Mar 15, 2023
vext01
reviewed
Mar 15, 2023
Ok(result) => Ok(result), | ||
Err(err) => Err(err), | ||
fn eval_statement(input: &str, calc: &mut Calc) -> Option<u64> { | ||
let statements: Vec<String> = input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better. I didn't realise that we were parsing line-by-line.
vext01
reviewed
Mar 15, 2023
Please squash. |
Pavel-Durov
force-pushed
the
semicolumn-separated-statements
branch
from
March 16, 2023 09:50
d8bb677
to
36e3d07
Compare
squashed 👉 36e3d07 |
bors r+ |
Build succeeded: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example: