Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#41 Escape output #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#41 Escape output #42

wants to merge 1 commit into from

Conversation

cmdmcs
Copy link
Contributor

@cmdmcs cmdmcs commented Feb 5, 2022

No description provided.

@cmdmcs cmdmcs requested a review from Programmer095 February 5, 2022 14:29
@Programmer095
Copy link
Contributor

Programmer095 commented Feb 8, 2022 •
edited
Loading

@cmdmcs It looks like the echo for helper_metabox_top() L419 should be escaped as it includes the slug and name in what's being echoed. We should probably escape helper_metabox_bottom L443 also for consistency.

The localization L868 should be removed also since they don't support variables.

@Programmer095
Copy link
Contributor

@cmdmcs just following up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Programmer095 Programmer095 Awaiting requested review from Programmer095

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmdmcs @Programmer095 @tsypliakov