Make all the thread name start with SOFA #85

liangyuanpeng · 2018-05-04T09:45:02Z

all the thread name start with SOFA
detail see #78

ujjboy · 2018-05-04T10:05:11Z

@liangyuanpeng You need run mvn clean compile before you start new PR.
See https://github.com/alipay/sofa-rpc/wiki/Contributing.

liangyuanpeng · 2018-05-04T10:08:28Z

hi，@ujjboy I've done this mvn clean compile
The reason for the failure is that "the command "sh ./tools/check_format.sh" failed and exited with 1 during "

ujjboy · 2018-05-04T10:35:11Z

No, I think you must did not run this before you commit code, otherwise It will not exists uncommit files. Just try again, and you will find NamedThreadFactory is not formatted.

liangyuanpeng · 2018-05-04T11:20:41Z

ok，my fault
so how can i do now？
create a new pr?

khotyn · 2018-05-04T11:23:02Z

@liangyuanpeng You don't have to create a new PR. You can just run mvn clean compile and commit all the reformat files and push to the origin branch of this PR, then all the check will be re-run automatically.

ujjboy · 2018-05-04T11:23:27Z

Just keep commit to your dev branch liangyuanpeng:enhancement_threadname_feature and CI will trigger a new build.

liangyuanpeng · 2018-05-04T11:30:13Z

@khotyn @ujjboy got it , thank you for help!!!

codecov-io · 2018-05-04T11:33:02Z

Codecov Report

Merging #85 into master will increase coverage by 0.05%.
The diff coverage is 90.9%.

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     63.84%   63.89%   +0.05%     
+ Complexity      596      595       -1     
============================================
  Files           263      263              
  Lines         11304    11304              
  Branches       1892     1892              
============================================
+ Hits           7217     7223       +6     
+ Misses         3114     3109       -5     
+ Partials        973      972       -1

Impacted Files	Coverage Δ	Complexity Δ
...java/com/alipay/sofa/rpc/context/AsyncRuntime.java	`53.84% <100%> (ø)`	`0 <0> (ø)`	⬇️
...pay/sofa/rpc/common/struct/NamedThreadFactory.java	`81.25% <100%> (+1.25%)`	`0 <0> (ø)`	⬇️
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java	`76.62% <100%> (ø)`	`21 <0> (ø)`	⬇️
...pay/sofa/rpc/server/rest/SofaNettyJaxrsServer.java	`60.78% <100%> (ø)`	`14 <1> (ø)`	⬇️
.../sofa/rpc/client/aft/impl/TimeWindowRegulator.java	`81.91% <100%> (ø)`	`7 <0> (ø)`	⬇️
...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java	`60.91% <50%> (+0.81%)`	`0 <0> (ø)`	⬇️
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java	`35% <0%> (-1%)`	`0% <0%> (ø)`
.../alipay/sofa/rpc/registry/local/LocalRegistry.java	`57.22% <0%> (-0.61%)`	`25% <0%> (-1%)`
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java	`80.24% <0%> (+1.23%)`	`0% <0%> (ø)`	⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java	`85.71% <0%> (+1.78%)`	`0% <0%> (ø)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ba240...bb7e804. Read the comment docs.

khotyn · 2018-05-04T11:38:44Z

core/common/src/main/java/com/alipay/sofa/rpc/common/struct/NamedThreadFactory.java

     */
-    public NamedThreadFactory(String prefix) {
-        this(prefix, false);
+    public NamedThreadFactory(String prefix2) {


Can you change the parameter name to secondPrefix? Because you have a field called firstPrefix, so I think secondPrefix is more suitable then prefix2

ujjboy · 2018-05-04T12:55:16Z

Hi, @liangyuanpeng!

The idea of automatically add prefix is good, but NamedThreadFactory will be used in UserThreadPool, if we add the first prefix automatically, the user will get different thread name with the name they expected.

So I suggest we don't change the behavior of NamedThreadFactory, just change the code which use UserThreadPool.

And you missed the files below:

com.alipay.sofa.rpc.bootstrap.DefaultProviderBootstrap#export

use code like:
```
new NamedThreadFactory("SOFA-DELAY-EXPORT").newThread(new Runnable());
```
com.alipay.sofa.rpc.server.bolt.BoltServer#initThreadPool
```
new NamedThreadFactory("SOFA-BOLT-BIZ")
```

liangyuanpeng · 2018-05-04T13:28:08Z

@ujjboy

I think start with "SOFA" just some like end with "-T"

public NamedThreadFactory(String prefix, boolean daemon) {
        SecurityManager s = System.getSecurityManager();
        group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
        namePrefix = prefix + "-" + POOL_COUNT.getAndIncrement() + "-T";
        isDaemon = daemon;
    }

and in my code , have no “SOFA-DELAY-EXPORT” and “SOFA-BOLT-BIZ”

com.alipay.sofa.rpc.bootstrap.DefaultProviderBootstrap#export

public void export() {
        if (providerConfig.getDelay() > 0) { // 延迟加载,单位毫秒
            Thread thread = new Thread(new Runnable() {
                @Override
                public void run() {
                    try {
                        Thread.sleep(providerConfig.getDelay());
                    } catch (Throwable ignore) { // NOPMD
                    }
                    doExport();
                }
            });
            thread.setDaemon(true);
            thread.setName("DelayExportThread");
            thread.start();
        } else {
            doExport();
        }
    }

2.com.alipay.sofa.rpc.server.bolt.BoltServer#initThreadPool

        threadPool.setThreadFactory(new NamedThreadFactory(
            "SofaBizProcessor-" + serverConfig.getPort(), serverConfig.isDaemon()));
        threadPool.setRejectedExecutionHandler(new SofaRejectedExecutionHandler());

ujjboy · 2018-05-04T14:24:56Z

@liangyuanpeng I means the code which you post need change to DELAY-EXPORT and BOLT-BIZ。

And I found you miss more code blow:

com.alipay.sofa.rpc.client.aft.impl.TimeWindowRegulator#measureScheduler
com.alipay.sofa.rpc.client.aft.impl.TimeWindowRegulator#regulationExecutor

liangyuanpeng · 2018-05-04T15:59:51Z

@ujjboy
do you mean some code like that

1.com.alipay.sofa.rpc.bootstrap.DefaultProviderBootstrap#export

Thread thread = new NamedThreadFactory("DELAY-EXPORT",true).newThread(new Runnable() {
                @Override
                public void run() {
                    try {
                        Thread.sleep(providerConfig.getDelay());
                    } catch (Throwable ignore) { // NOPMD
                    }
                    doExport();
                }
            });
            thread.start();

2.com.alipay.sofa.rpc.server.bolt.BoltServer#initThreadPool

ThreadPoolExecutor threadPool = BusinessPool.initPool(serverConfig);
        threadPool.setThreadFactory(new NamedThreadFactory(
            "BOLT-BIZ" + serverConfig.getPort(), serverConfig.isDaemon()));
        threadPool.setRejectedExecutionHandler(new SofaRejectedExecutionHandler());

ujjboy · 2018-05-04T16:39:46Z

@liangyuanpeng 👍 Yes, that is what I mean.

And new NamedThreadFactory("DELAY-EXPORT",true) can be a field, and then create as needed.

leizhiyuan · 2018-05-05T02:38:50Z

extension-impl/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServer.java

@@ -87,7 +87,7 @@ public void init(ServerConfig serverConfig) {
    protected ThreadPoolExecutor initThreadPool(ServerConfig serverConfig) {
        ThreadPoolExecutor threadPool = BusinessPool.initPool(serverConfig);
        threadPool.setThreadFactory(new NamedThreadFactory(
-            "SofaBizProcessor-" + serverConfig.getPort(), serverConfig.isDaemon()));
+            "BOLT-BIZ" + serverConfig.getPort(), serverConfig.isDaemon()));


maybe "BOLT-BIZ-" ?

…peng/sofa-rpc into enhancement_threadname_feature

all the thread name start with SOFA

9e7b79d

format NamedThreadFactory

63012bd

khotyn requested changes May 4, 2018

View reviewed changes

change field prefix2 to secondPrefix

6317053

liangyuanpeng and others added 3 commits May 5, 2018 10:34

clean up the thread name

be4e142

clean up the thread name

d772e61

Merge branch 'master' into enhancement_threadname_feature

7cb5bcd

leizhiyuan reviewed May 5, 2018

View reviewed changes

ujjboy approved these changes May 5, 2018

View reviewed changes

liangyuanpeng added 2 commits May 5, 2018 10:43

clean up the thread name

983e92e

Merge branch 'enhancement_threadname_feature' of github.com:liangyuan…

bb7e804

…peng/sofa-rpc into enhancement_threadname_feature

leizhiyuan approved these changes May 5, 2018

View reviewed changes

ujjboy merged commit 3e8aab8 into sofastack:master May 5, 2018

ujjboy added the enhancement New feature or request label May 5, 2018

ujjboy added this to the 5.4.0 milestone May 5, 2018

ujjboy changed the title ~~all the thread name start with SOFA~~ Make all the thread name start with SOFA May 30, 2018

liangyuanpeng deleted the enhancement_threadname_feature branch August 27, 2018 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make all the thread name start with SOFA #85

Make all the thread name start with SOFA #85

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018

khotyn commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018

liangyuanpeng commented May 4, 2018

codecov-io commented May 4, 2018 •

edited

Loading

khotyn May 4, 2018

ujjboy commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018

leizhiyuan May 5, 2018

Make all the thread name start with SOFA #85

Make all the thread name start with SOFA #85

Conversation

liangyuanpeng commented May 4, 2018 • edited Loading

ujjboy commented May 4, 2018

liangyuanpeng commented May 4, 2018 • edited Loading

ujjboy commented May 4, 2018 • edited Loading

liangyuanpeng commented May 4, 2018

khotyn commented May 4, 2018 • edited Loading

ujjboy commented May 4, 2018

liangyuanpeng commented May 4, 2018

codecov-io commented May 4, 2018 • edited Loading

Codecov Report

khotyn May 4, 2018

Choose a reason for hiding this comment

ujjboy commented May 4, 2018 • edited Loading

liangyuanpeng commented May 4, 2018 • edited Loading

ujjboy commented May 4, 2018 • edited Loading

liangyuanpeng commented May 4, 2018 • edited Loading

ujjboy commented May 4, 2018

leizhiyuan May 5, 2018

Choose a reason for hiding this comment

liangyuanpeng commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018 •

edited

Loading

khotyn commented May 4, 2018 •

edited

Loading

codecov-io commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018 •

edited

Loading

ujjboy commented May 4, 2018 •

edited

Loading

liangyuanpeng commented May 4, 2018 •

edited

Loading