Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when invoke asynchronously use JDKProxy. #77

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 3, 2018

Fix #75

@ujjboy ujjboy added the bug Something isn't working label May 3, 2018
@ujjboy ujjboy added this to the 5.3.2 milestone May 3, 2018
@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #77 into 5.3 will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.3      #77      +/-   ##
============================================
+ Coverage     63.44%   63.49%   +0.05%     
- Complexity      583      584       +1     
============================================
  Files           263      263              
  Lines         11226    11228       +2     
  Branches       1871     1872       +1     
============================================
+ Hits           7122     7129       +7     
  Misses         3136     3136              
+ Partials        968      963       -5
Impacted Files Coverage Δ Complexity Δ
...lipay/sofa/rpc/proxy/jdk/JDKInvocationHandler.java 80.76% <100%> (+1.6%) 0 <0> (ø) ⬇️
.../com/alipay/sofa/rpc/log/MiddlewareLoggerImpl.java 76.81% <0%> (-5.8%) 0% <0%> (ø)
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 57.83% <0%> (+0.6%) 26% <0%> (+1%) ⬆️
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java 36% <0%> (+1%) 0% <0%> (ø) ⬇️
.../java/com/alipay/sofa/rpc/log/SLF4JLoggerImpl.java 100% <0%> (+1.51%) 0% <0%> (ø) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 85.71% <0%> (+1.78%) 0% <0%> (ø) ⬇️
...lipay/sofa/rpc/proxy/javassist/JavassistProxy.java 79.06% <0%> (+3.87%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921096d...2f49488. Read the comment docs.

@ujjboy ujjboy merged commit 7d54cfe into 5.3 May 3, 2018
@ujjboy ujjboy deleted the fix_issue_75 branch May 3, 2018 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants