Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix select typo #73

Merged
merged 1 commit into from
May 2, 2018
Merged

fix select typo #73

merged 1 commit into from
May 2, 2018

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented May 1, 2018 •
edited by khotyn
Loading

@codecov-io
Copy link

codecov-io commented May 1, 2018 •
edited
Loading

Codecov Report

Merging #73 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     63.56%   63.52%   -0.05%     
+ Complexity      594      592       -2     
============================================
  Files           263      263              
  Lines         11294    11294              
  Branches       1887     1887              
============================================
- Hits           7179     7174       -5     
- Misses         3148     3151       +3     
- Partials        967      969       +2
Impacted Files Coverage Δ Complexity Δ
...sofa/rpc/client/lb/ConsistentHashLoadBalancer.java 77.35% <100%> (ø) 0 <0> (ø) ⬇️
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 83.65% <0%> (-2.89%) 22% <0%> (-1%)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 76.62% <0%> (-1.3%) 21% <0%> (-1%)
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 52.51% <0%> (-0.28%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238c4e3...9b0dc6b. Read the comment docs.

ujjboy
ujjboy requested changes May 2, 2018
View reviewed changes
example/src/test/java/com/alipay/sofa/rpc/quickstart/QuickStartClient.java Outdated
@@ -32,9 +32,16 @@ public static void main(String[] args) {

HelloService helloService = consumerConfig.refer();

//wait address to receive and connect successfully
Copy link
Member

@ujjboy ujjboy May 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to sleep here, you can use consumerConfig.setConnectTimeout(10000) (default is 3000) for waiting slow connection.

@leizhiyuan
Copy link
Contributor Author

@ujjboy fixed

@leizhiyuan
1.fix select typo
9b0dc6b 
2.optimize quickstart
@ujjboy ujjboy merged commit 500b12f into sofastack:master May 2, 2018
ujjboy pushed a commit that referenced this pull request May 2, 2018
@leizhiyuan @ujjboy
Fix typo. (#73)
921096d 
(cherry picked from commit 500b12f)
@leizhiyuan leizhiyuan deleted the fix-select-typo branch May 2, 2018 23:56
@ujjboy ujjboy added this to the 5.3.2 milestone May 3, 2018
@ujjboy ujjboy added the bug Something isn't working label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

ConsistentHashLoadBalancer.sekectForKey(long hash) 是不是错别字了？
3 participants
@leizhiyuan @codecov-io @ujjboy