Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need use RpcInternalContext when subscribe event asynchronously. #47

Merged
merged 2 commits into from
Apr 28, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Apr 24, 2018

#46

@ujjboy ujjboy added the enhancement New feature or request label Apr 24, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone Apr 24, 2018
@ujjboy ujjboy self-assigned this Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
+ Coverage     63.26%   63.53%   +0.26%     
- Complexity      592      594       +2     
============================================
  Files           263      263              
  Lines         10874    11278     +404     
  Branches       1820     1884      +64     
============================================
+ Hits           6879     7165     +286     
- Misses         3040     3144     +104     
- Partials        955      969      +14
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 72.34% <66.66%> (-0.84%) 0 <0> (ø)
...java/com/alipay/sofa/rpc/context/AsyncRuntime.java 53.84% <0%> (-9.8%) 0% <0%> (ø)
...com/alipay/sofa/rpc/common/utils/ReflectUtils.java 61.62% <0%> (-6.56%) 0% <0%> (ø)
...alipay/sofa/rpc/api/future/SofaResponseFuture.java 55.17% <0%> (-6.37%) 5% <0%> (ø)
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 60.44% <0%> (-6.22%) 0% <0%> (ø)
...ay/sofa/rpc/protocol/telnet/HelpTelnetHandler.java 82.35% <0%> (-5.15%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/client/FailoverCluster.java 74.28% <0%> (-4.29%) 0% <0%> (ø)
.../sofa/rpc/registry/zk/ZookeeperConfigObserver.java 29.41% <0%> (-3.93%) 0% <0%> (ø)
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 83.65% <0%> (-3.85%) 22% <0%> (-1%)
...va/com/alipay/sofa/rpc/client/FailFastCluster.java 75% <0%> (-2.78%) 0% <0%> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ad19f...e7558e9. Read the comment docs.

@ujjboy ujjboy merged commit f10ee0e into sofastack:master Apr 28, 2018
@ujjboy ujjboy deleted the event_bus_async branch April 28, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants