Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception which throws on the listener notifying when loading extension success. #229

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Jul 16, 2018

Modification:

  • Catch exception which throws on the listener notifying when loading extension success.
  • Add test case.

Result:

Fix #224

@ujjboy ujjboy added the optimization Code optimization label Jul 16, 2018
@ujjboy ujjboy added this to the 5.4.3 milestone Jul 16, 2018
@ujjboy ujjboy requested a review from leizhiyuan July 16, 2018 11:52
@ujjboy ujjboy merged commit fc94ceb into sofastack:5.4 Jul 16, 2018
@codecov-io
Copy link

Codecov Report

Merging #229 into 5.4 will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.4     #229      +/-   ##
============================================
- Coverage     71.53%   71.45%   -0.09%     
+ Complexity      961      960       -1     
============================================
  Files           341      341              
  Lines         14234    14238       +4     
  Branches       2290     2289       -1     
============================================
- Hits          10183    10174       -9     
- Misses         2858     2865       +7     
- Partials       1193     1199       +6
Impacted Files Coverage Δ Complexity Δ
.../java/com/alipay/sofa/rpc/ext/ExtensionLoader.java 82.14% <100%> (+0.37%) 0 <0> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 72.3% <0%> (-6.16%) 0% <0%> (ø)
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 42.3% <0%> (-2.57%) 0% <0%> (ø)
.../sofa/rpc/registry/zk/ZookeeperRegistryHelper.java 75.86% <0%> (-1.38%) 0% <0%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 89.02% <0%> (-1.22%) 0% <0%> (ø)
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java 89.21% <0%> (-0.99%) 0% <0%> (ø)
...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java 59.37% <0%> (-0.79%) 0% <0%> (ø)
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 65.66% <0%> (-0.61%) 28% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b4176...a4831d2. Read the comment docs.

@ujjboy ujjboy deleted the fix_224 branch July 17, 2018 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants