Use multiple separate counters for the single service with multiple protocols. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.4 #222 +/- ##
============================================
+ Coverage 71.13% 71.49% +0.35%
Complexity 961 961
============================================
Files 341 341
Lines 13654 14238 +584
Branches 2208 2290 +82
============================================
+ Hits 9713 10179 +466
- Misses 2763 2865 +102
- Partials 1178 1194 +16
Continue to review full report at Codecov.
|
ujjboy
requested changes
Jul 9, 2018
| String protocol = serverConfig.getProtocol(); | ||
| String key = providerConfig.buildKey() + ":" + protocol; | ||
| AtomicInteger cnt = EXPORTED_KEYS.get(key); // 计数器 | ||
| if (cnt != null && cnt.get() > 0) { |
There was a problem hiding this comment.
这里应该记录下已经增加的计数器，而不是全部计数器。 例如发布A、B、C协议，发到 B 的时候失败，应该只需要减去 A 的计数器即可，B 和 C 的计数器都不需要减。
There was a problem hiding this comment.
这个抛出异常的时候,比较难记录.. register();因为这行代码可能跑错.
There was a problem hiding this comment.
如果 register() 抛错， 那说明 A B C 都发布完了。 我举的例子应该是还在发 B 协议的时候。
ujjboy
requested changes
Jul 12, 2018
| @@ -164,6 +176,7 @@ private void doExport() { | |||
| if (serverConfig.isAutoStart()) { | |||
| server.start(); | |||
| } | |||
| hasExportedInCurrent.put(serverConfig.getProtocol(), true); | |||
There was a problem hiding this comment.
我看计数器加1的地方是在 131 行的地方加的，在这个位置记录加1的情况应该会有不对应的问题。
There was a problem hiding this comment.
这个地方是为了记录本次 export 成功了哪个协议.是一个局部的操作.
ujjboy
requested changes
Jul 13, 2018
|
|
||
| Assert.fail(); | ||
| } catch (Throwable e) { | ||
| Assert.assertTrue(true); |
ujjboy
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix sofastack/sofa-rpc-boot-projects#67
Modification:
Describe the idea and modifications you've done.
Result:
Fixes sofastack/sofa-rpc-boot-projects#67