Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnsupportedOperationException thrown in notifyListeners #206

Merged

Conversation

ScienJus
Copy link
Member

Result:

Fixes #194

@codecov-io
Copy link

Codecov Report

Merging #206 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #206      +/-   ##
===========================================
- Coverage     71.62%   71.3%   -0.32%     
+ Complexity      968     957      -11     
===========================================
  Files           341     341              
  Lines         14213   14213              
  Branches       2286    2286              
===========================================
- Hits          10180   10135      -45     
- Misses         2839    2882      +43     
- Partials       1194    1196       +2
Impacted Files Coverage Δ Complexity Δ
...ipay/sofa/rpc/message/bolt/BoltResponseFuture.java 70% <ø> (ø) 4 <0> (ø) ⬇️
...y/sofa/rpc/registry/local/LocalRegistryHelper.java 42.98% <0%> (-18.43%) 10% <0%> (-6%)
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 57.22% <0%> (-12.05%) 25% <0%> (-3%)
...m/alipay/sofa/rpc/common/struct/MapDifference.java 75.67% <0%> (-10.82%) 0% <0%> (ø)
...pay/sofa/rpc/transport/ClientTransportFactory.java 73.84% <0%> (-4.62%) 0% <0%> (ø)
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 70.73% <0%> (-2.44%) 10% <0%> (-1%)
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 84.44% <0%> (-2.23%) 26% <0%> (-1%)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 83.92% <0%> (-1.79%) 0% <0%> (ø)
.../sofa/rpc/registry/zk/ZookeeperRegistryHelper.java 75% <0%> (-1.43%) 0% <0%> (ø)
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java 89.21% <0%> (-0.99%) 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e63bd...e19f38a. Read the comment docs.

@ujjboy ujjboy added the optimization Code optimization label Jun 29, 2018
@ujjboy ujjboy added this to the 5.4.2 milestone Jun 29, 2018
@ujjboy ujjboy merged commit e72bca3 into sofastack:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants