Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and add more test cases. #177

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Jun 13, 2018

Modification:

  1. Fix some possible NPE.
  2. Add more test case.

@ujjboy ujjboy added the optimization Code optimization label Jun 13, 2018
@ujjboy ujjboy added this to the 5.4.1 milestone Jun 13, 2018
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #177 into master will increase coverage by 1.93%.
The diff coverage is 64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #177      +/-   ##
============================================
+ Coverage        69%   70.94%   +1.93%     
+ Complexity      955      954       -1     
============================================
  Files           341      341              
  Lines         14194    14196       +2     
  Branches       2278     2281       +3     
============================================
+ Hits           9795    10071     +276     
+ Misses         3235     2947     -288     
- Partials       1164     1178      +14
Impacted Files Coverage Δ Complexity Δ
.../java/com/alipay/sofa/rpc/ext/ExtensionLoader.java 81.77% <ø> (-0.1%) 0 <0> (ø)
.../sofa/rpc/client/aft/impl/TimeWindowRegulator.java 81.91% <ø> (ø) 7 <0> (ø) ⬇️
.../java/com/alipay/sofa/rpc/server/BusinessPool.java 85.71% <ø> (+58.44%) 0 <0> (ø) ⬇️
...lipay/sofa/rpc/config/AbstractInterfaceConfig.java 46.39% <0%> (-0.43%) 0 <0> (ø)
.../java/com/alipay/sofa/rpc/config/MethodConfig.java 53.65% <0%> (-2.76%) 0 <0> (ø)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 72.22% <0%> (-1.65%) 23 <0> (ø)
...lipay/sofa/rpc/message/AbstractResponseFuture.java 53.57% <100%> (ø) 0 <0> (ø) ⬇️
...va/com/alipay/sofa/rpc/server/rest/RestServer.java 80.76% <100%> (+17.04%) 0 <0> (ø) ⬇️
...om/alipay/sofa/rpc/common/json/BeanSerializer.java 66.27% <100%> (ø) 0 <0> (ø) ⬇️
...in/java/com/alipay/sofa/rpc/common/SystemInfo.java 92.85% <100%> (+29.22%) 0 <0> (ø) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0b068...d9235f8. Read the comment docs.

@ujjboy ujjboy merged commit 3e63253 into sofastack:master Jun 15, 2018
@ujjboy ujjboy deleted the code_cleanup branch June 15, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants