-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP/2 protocol. #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
============================================
+ Coverage 68.03% 68.58% +0.54%
- Complexity 714 944 +230
============================================
Files 304 339 +35
Lines 12743 14156 +1413
Branches 2088 2268 +180
============================================
+ Hits 8670 9709 +1039
- Misses 3026 3278 +252
- Partials 1047 1169 +122
Continue to review full report at Codecov.
|
It seems tracer is not ok
server lost tracerId and span Id, I will check
|
io.netty.handler.codec.http2.HttpConversionUtil#toHttp2Headers(io.netty.handler.codec.http.HttpHeaders, io.netty.handler.codec.http2.Http2Headers) netty convert header to lowercase. when we receive in server. rpc_trace_context.sofaRpcId will become rpc_trace_context.sofarpcid this is a http2 sepc. we need to get lower case key when we resolve
maybe we need hold a convert relationship to fetch ?
|
@leizhiyuan I have fixed it. See |
now, tracer is ok |
Motivation:
Support HTTP/1.1 & HTTP/2 protocol.
Modification:
Result:
Fix #25