-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc unique id character check support disable #1275
rpc unique id character check support disable #1275
Conversation
core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
Show resolved
Hide resolved
core/common/src/main/java/com/alipay/sofa/rpc/common/config/RpcConfigKeys.java
Outdated
Show resolved
Hide resolved
core/common/src/main/java/com/alipay/sofa/rpc/common/config/RpcConfigKeys.java
Outdated
Show resolved
Hide resolved
core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
Outdated
Show resolved
Hide resolved
core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
============================================
- Coverage 72.21% 72.21% -0.01%
+ Complexity 782 780 -2
============================================
Files 412 412
Lines 17467 17468 +1
Branches 2723 2723
============================================
Hits 12614 12614
- Misses 3466 3470 +4
+ Partials 1387 1384 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -68,19 +70,19 @@ | |||
/** | |||
* The constant serialVersionUID. | |||
*/ | |||
private static final long serialVersionUID = -8738241729920479618L; | |||
private static final long serialVersionUID = -8738241729920479618L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr不要展示无效的变更
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sofa rpc 中 限制了需要格式化代码之后才能提交PR,这样能保证全局的统一的代码格式,也有益处。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样影响pr的review,如果需要统一格式化,就专门用一个pr把这个问题解决掉
core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
Outdated
Show resolved
Hide resolved
core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1274