Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc unique id character check support disable #1275

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

taobaorun
Copy link
Contributor

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/M labels Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1275 (8c863db) into master (d53562a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1275      +/-   ##
============================================
- Coverage     72.21%   72.21%   -0.01%     
+ Complexity      782      780       -2     
============================================
  Files           412      412              
  Lines         17467    17468       +1     
  Branches       2723     2723              
============================================
  Hits          12614    12614              
- Misses         3466     3470       +4     
+ Partials       1387     1384       -3     
Impacted Files Coverage Δ
...in/java/com/alipay/sofa/rpc/common/RpcOptions.java 100.00% <ø> (ø)
...lipay/sofa/rpc/config/AbstractInterfaceConfig.java 76.66% <100.00%> (+0.09%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...m/alipay/sofa/rpc/codec/jackson/JacksonHelper.java 82.05% <0.00%> (-2.57%) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <0.00%> (-1.07%) ⬇️
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 81.48% <0.00%> (-0.93%) ⬇️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 90.12% <0.00%> (+1.23%) ⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0.00%> (+1.53%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -68,19 +70,19 @@
/**
* The constant serialVersionUID.
*/
private static final long serialVersionUID = -8738241729920479618L;
private static final long serialVersionUID = -8738241729920479618L;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr不要展示无效的变更

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sofa rpc 中 限制了需要格式化代码之后才能提交PR,这样能保证全局的统一的代码格式,也有益处。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样影响pr的review,如果需要统一格式化,就专门用一个pr把这个问题解决掉

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy added this to the 5.9.0 milestone Nov 7, 2022
@ujjboy ujjboy merged commit 935aa63 into sofastack:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants