Integrate with sofa-lookout for support metrics 2.0. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the order of events and record elapsed time when async invoke.…
Closed
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
============================================
+ Coverage 65.74% 66.44% +0.69%
- Complexity 685 756 +71
============================================
Files 272 280 +8
Lines 11626 11904 +278
Branches 1961 1981 +20
============================================
+ Hits 7644 7910 +266
+ Misses 3015 3006 -9
- Partials 967 988 +21
Continue to review full report at Codecov.
|
ujjboy
requested changes
May 17, 2018
|
|
||
| @Override | ||
| public boolean needLoad() { | ||
| return true; |
| static { | ||
| LookoutSubscriber.setLookoutCollectDisable(true); | ||
| } | ||
|
|
There was a problem hiding this comment.
让之前的rpc调用不收集metrics信息，避免在lookout的用例初始化lookout的registry之前对registry进行了初始化。如果提前初始化了就会导致registry是一个noop。
There was a problem hiding this comment.
这段逻辑挪到 LookoutSubscriber 里去吧。 If(RpcRunningState.isUnitTestMode())
| /** | ||
| * | ||
| * @author <a href="mailto:lw111072@antfin.com">LiWei.Liengen</a> | ||
| * @version $Id: BoltServerStartedEvent.java, v 0.1 2018年04月24日 下午10:57 LiWei.Liengen Exp $ |
| <artifactId>lookout-api</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
There was a problem hiding this comment.
<build></build> 从别的 module里复制过来。
|
|
||
| private final RpcLookoutId rpcLookoutId = new RpcLookoutId(); | ||
|
|
||
| private static final String EMPTY_STRING = ""; |
| * @author <a href="mailto:lw111072@antfin.com">LiWei.Liangen</a> | ||
| * @version $Id: LookoutService.java, v 0.1 2018年05月10日 下午10:56 LiWei.Liangen Exp $ | ||
| */ | ||
| public interface LookoutService { |
There was a problem hiding this comment.
这几个用例依赖第三方服务端吗？如果不依赖，挪到 test-integration 模块下去。
ujjboy
requested changes
May 18, 2018
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <skipTests>${dependency.test.skip}</skipTests> |
| static { | ||
| LookoutSubscriber.setLookoutCollectDisable(true); | ||
| } | ||
|
|
There was a problem hiding this comment.
这段逻辑挪到 LookoutSubscriber 里去吧。 If(RpcRunningState.isUnitTestMode())
ujjboy
requested changes
May 21, 2018
| public void uninstall() { | ||
| if (subscriber != null) { | ||
| EventBus.unRegister(ClientEndInvokeEvent.class, subscriber); | ||
| EventBus.unRegister(ClientAsyncReceiveEvent.class, subscriber); |
There was a problem hiding this comment.
ClientAsyncReceiveEvent 这个事件不需要了吧。
| public void install() { | ||
| subscriber = new LookoutSubscriber(); | ||
| EventBus.register(ClientEndInvokeEvent.class, subscriber); | ||
| EventBus.register(ClientAsyncReceiveEvent.class, subscriber); |
There was a problem hiding this comment.
ClientAsyncReceiveEvent 这个事件不需要了吧。
ujjboy
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add the lookout module, report the information to lookout.
Modification:
Add lookout module.
A LookoutSubscriber was declared to monitor bolt thread pool status and call information.
Add lookout-api dependency.
Result:
If the "lookout. collect. disable" is false. The call information will be collected and reported to lookout.