Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DoaminRegistry multi inited #1257

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

OrezzerO
Copy link
Contributor

fix DoaminRegistry multi inited

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/M labels Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1257 (93cb084) into master (dabc7b8) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1257      +/-   ##
============================================
- Coverage     72.14%   72.09%   -0.06%     
- Complexity      780      781       +1     
============================================
  Files           411      411              
  Lines         17418    17420       +2     
  Branches       2714     2714              
============================================
- Hits          12567    12559       -8     
- Misses         3466     3474       +8     
- Partials       1385     1387       +2     
Impacted Files Coverage Δ
...alipay/sofa/rpc/registry/local/DomainRegistry.java 94.26% <100.00%> (+0.09%) ⬆️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.86% <0.00%> (-4.73%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 90.32% <0.00%> (-0.75%) ⬇️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (+1.58%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj requested review from chuailiwu and JervyShi October 26, 2022 02:30
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit ea21ef8 into sofastack:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants