Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triple class loader problem #1216

Merged
merged 6 commits into from
Jul 19, 2022
Merged

fix triple class loader problem #1216

merged 6 commits into from
Jul 19, 2022

Conversation

OrezzerO
Copy link
Contributor

Motivation:

In ark environment ,Triple server should choose correct class loader to processor request.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/M labels Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1216 (dff0d9e) into master (bb7c51b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1216      +/-   ##
============================================
- Coverage     71.56%   71.56%   -0.01%     
+ Complexity      832      830       -2     
============================================
  Files           408      408              
  Lines         17224    17234      +10     
  Branches       2684     2685       +1     
============================================
+ Hits          12327    12333       +6     
- Misses         3533     3534       +1     
- Partials       1364     1367       +3     
Impacted Files Coverage Δ
...com/alipay/sofa/rpc/common/cache/ReflectCache.java 89.65% <100.00%> (ø)
...pay/sofa/rpc/server/triple/GenericServiceImpl.java 87.93% <100.00%> (+0.65%) ⬆️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <100.00%> (+0.97%) ⬆️
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java 72.50% <0.00%> (-2.50%) ⬇️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 88.63% <0.00%> (-2.28%) ⬇️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 87.30% <0.00%> (-1.59%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7c51b...dff0d9e. Read the comment docs.

@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Jun 22, 2022
Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj added this to the 5.8.6 milestone Jul 13, 2022
Copy link
Collaborator

@leslieSll leslieSll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrezzerO OrezzerO merged commit ebb7026 into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants