Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/concurrency problem in deque local #1203

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented May 6, 2022

Motivation:

DEQUE_LOCAL in RpcInternalContext only be responsible for holder B context in A->B->C, so it no need to clone from parent thread.

Modification:

DEQUE_LOCAL replace to ThreadLocal.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/M labels May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1203 (7eb9011) into master (d107d22) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1203      +/-   ##
============================================
+ Coverage     71.53%   71.63%   +0.09%     
  Complexity      830      830              
============================================
  Files           408      408              
  Lines         17224    17224              
  Branches       2684     2684              
============================================
+ Hits          12322    12339      +17     
+ Misses         3535     3521      -14     
+ Partials       1367     1364       -3     
Impacted Files Coverage Δ
...om/alipay/sofa/rpc/context/RpcInternalContext.java 82.88% <100.00%> (ø)
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 80.27% <0.00%> (+2.04%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 68.11% <0.00%> (+2.89%) ⬆️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 84.00% <0.00%> (+4.00%) ⬆️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 69.59% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d107d22...7eb9011. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 55c5446 into sofastack:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants