-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/concurrency problem in deque local #1203
Fix/concurrency problem in deque local #1203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
============================================
+ Coverage 71.53% 71.63% +0.09%
Complexity 830 830
============================================
Files 408 408
Lines 17224 17224
Branches 2684 2684
============================================
+ Hits 12322 12339 +17
+ Misses 3535 3521 -14
+ Partials 1367 1364 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
DEQUE_LOCAL in RpcInternalContext only be responsible for holder B context in A->B->C, so it no need to clone from parent thread.
Modification:
DEQUE_LOCAL replace to ThreadLocal.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.