Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consul registry support acl(#1168) #1169

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

Kunple-w
Copy link
Contributor

Motivation:

consul registry support acl

Modification:

  1. consul registry support parameter token;
  2. test unit for consul registry acl;

Result:

Fixes #1168

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok First-time contributor First-time contributor size/L labels Feb 20, 2022
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #1169 (781382a) into master (ebae921) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1169      +/-   ##
============================================
+ Coverage     71.05%   71.15%   +0.10%     
+ Complexity      829      827       -2     
============================================
  Files           406      407       +1     
  Lines         17134    17197      +63     
  Branches       2671     2681      +10     
============================================
+ Hits          12174    12237      +63     
+ Misses         3587     3586       -1     
- Partials       1373     1374       +1     
Impacted Files Coverage Δ
...ipay/sofa/rpc/registry/consul/ConsulConstants.java 50.00% <ø> (ø)
...lipay/sofa/rpc/registry/consul/ConsulRegistry.java 47.80% <100.00%> (ø)
.../rpc/registry/consul/ConsulRegistryProperties.java 74.07% <100.00%> (+12.53%) ⬆️
...ofa/rpc/registry/consul/HealthServiceInformer.java 84.78% <100.00%> (+0.69%) ⬆️
...ava/com/alipay/sofa/rpc/common/MetadataHolder.java 0.00% <0.00%> (-90.00%) ⬇️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 75.00% <0.00%> (-6.19%) ⬇️
...pay/sofa/rpc/client/aft/InvocationStatFactory.java 87.50% <0.00%> (-5.00%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 66.41% <0.00%> (-2.24%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebae921...781382a. Read the comment docs.

@Kunple-w Kunple-w force-pushed the add_consul_registry_acl_feature branch from b36bdd6 to 781382a Compare February 21, 2022 14:24
Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj added this to the 5.8.4 milestone Mar 2, 2022
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 4b072c0 into sofastack:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok First-time contributor First-time contributor size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用consul作为注册中心,不支持配置acl
3 participants