Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RpcInvokeContext when triple invoke completed #1167

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

OrezzerO
Copy link
Contributor

remove RpcInvokeContext when triple invoke completed

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok question Further information is requested size/M labels Feb 17, 2022
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1167 (4b187b4) into master (3229fa0) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1167      +/-   ##
============================================
- Coverage     71.20%   71.06%   -0.14%     
  Complexity      825      825              
============================================
  Files           407      407              
  Lines         17194    17199       +5     
  Branches       2681     2681              
============================================
- Hits          12243    12223      -20     
- Misses         3576     3598      +22     
- Partials       1375     1378       +3     
Impacted Files Coverage Δ
...fa/rpc/interceptor/ServerReqHeaderInterceptor.java 90.76% <100.00%> (+0.60%) ⬆️
...ofa/rpc/tracer/sofatracer/TripleTracerAdapter.java 60.74% <100.00%> (+0.29%) ⬆️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 63.63% <0.00%> (-31.82%) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.86% <0.00%> (-4.73%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...ansport/bolt/ReuseBoltClientConnectionManager.java 65.21% <0.00%> (-2.90%) ⬇️
...alipay/sofa/rpc/server/triple/UniqueIdInvoker.java 73.17% <0.00%> (-2.44%) ⬇️
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 78.43% <0.00%> (-1.97%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 73.88% <0.00%> (-1.12%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3229fa0...4b187b4. Read the comment docs.

@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Feb 21, 2022
@OrezzerO OrezzerO merged commit 0b026af into sofastack:master Feb 22, 2022
@EvenLjj EvenLjj added this to the 5.8.3 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok question Further information is requested size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants