-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-destroy方法的错误代码 #1164
fix-destroy方法的错误代码 #1164
Conversation
虽然这个不会出bug,但是为了严谨高质量还是得改下。
Hi @yuzd, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
============================================
+ Coverage 71.06% 71.17% +0.11%
+ Complexity 826 825 -1
============================================
Files 407 407
Lines 17180 17180
Branches 2679 2679
============================================
+ Hits 12209 12228 +19
+ Misses 3596 3575 -21
- Partials 1375 1377 +2
Continue to review full report at Codecov.
|
@leizhiyuan @JervyShi @EvenLjj pls review this PR, thanks |
core-impl/client/src/main/java/com/alipay/sofa/rpc/client/AbstractCluster.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
hook应该先preDestory
Modification:
虽然这个不会出bug,但是为了严谨和高质量