Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix baggage contains null #1140

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Conversation

OrezzerO
Copy link
Contributor

@OrezzerO OrezzerO commented Dec 1, 2021

Motivation:

If baggage contains null value, putAll method of. ConcurrentHashMap will throw NPE.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/M labels Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1140 (e425e01) into master (303ae5e) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1140      +/-   ##
============================================
- Coverage     71.07%   71.00%   -0.08%     
+ Complexity      833      831       -2     
============================================
  Files           405      405              
  Lines         17100    17108       +8     
  Branches       2669     2670       +1     
============================================
- Hits          12154    12147       -7     
- Misses         3561     3582      +21     
+ Partials       1385     1379       -6     
Impacted Files Coverage Δ
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 81.48% <100.00%> (+0.48%) ⬆️
...fa/rpc/transport/http/SyncInvokeClientHandler.java 51.85% <0.00%> (-33.34%) ⬇️
.../rpc/transport/http/Http2ClientChannelHandler.java 60.52% <0.00%> (-15.79%) ⬇️
...ipay/sofa/rpc/message/http/HttpResponseFuture.java 46.66% <0.00%> (-4.45%) ⬇️
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 80.39% <0.00%> (-3.93%) ⬇️
...c/transport/http/AbstractHttp2ClientTransport.java 76.64% <0.00%> (-2.40%) ⬇️
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.76% <0.00%> (+1.02%) ⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0.00%> (+1.53%) ⬆️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 90.47% <0.00%> (+1.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303ae5e...e425e01. Read the comment docs.

Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi added this to the 5.8.2 milestone Dec 4, 2021
@JervyShi JervyShi merged commit 7b3b402 into sofastack:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants