Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the way we set custom header in triple protocol #1138

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

OrezzerO
Copy link
Contributor

Motivation:

Modify the way we set custom header in triple protocol

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/L labels Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1138 (f26ebc2) into master (303ae5e) will increase coverage by 0.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1138   +/-   ##
=========================================
  Coverage     71.07%   71.08%           
  Complexity      833      833           
=========================================
  Files           405      405           
  Lines         17100    17098    -2     
  Branches       2669     2669           
=========================================
  Hits          12154    12154           
- Misses         3561     3563    +2     
+ Partials       1385     1381    -4     
Impacted Files Coverage Δ
...ava/com/alipay/sofa/rpc/common/MetadataHolder.java 0.00% <ø> (-90.00%) ⬇️
...ofa/rpc/tracer/sofatracer/TripleTracerAdapter.java 59.54% <80.00%> (+5.27%) ⬆️
...ay/sofa/rpc/filter/ConsumerCustomHeaderFilter.java 100.00% <100.00%> (ø)
...y/sofa/rpc/filter/PressureMarkTransformFilter.java 100.00% <100.00%> (ø)
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 80.39% <0.00%> (-3.93%) ⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0.00%> (+1.23%) ⬆️
...lipay/sofa/rpc/proxy/javassist/JavassistProxy.java 80.00% <0.00%> (+1.33%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 68.11% <0.00%> (+2.89%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303ae5e...f26ebc2. Read the comment docs.

@EvenLjj EvenLjj added this to the 5.8.2 milestone Dec 5, 2021
Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 4a0e099 into sofastack:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants