Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1091, upgrade sofa hessian version #1110

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

wangchengming666
Copy link
Collaborator

issue #1091

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok First-time contributor First-time contributor size/XS labels Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1110 (36b5ae7) into master (8572e25) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1110      +/-   ##
============================================
- Coverage     69.05%   69.03%   -0.03%     
+ Complexity      830      829       -1     
============================================
  Files           409      409              
  Lines         17721    17721              
  Branches       2749     2749              
============================================
- Hits          12237    12233       -4     
- Misses         4067     4069       +2     
- Partials       1417     1419       +2     
Impacted Files Coverage Δ
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 78.23% <0.00%> (-2.05%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
...lipay/sofa/rpc/registry/consul/ConsulRegistry.java 47.25% <0.00%> (-0.55%) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8572e25...36b5ae7. Read the comment docs.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchengming666
Copy link
Collaborator Author

@JervyShi @leizhiyuan pls help review this PR, thanks

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit f75d3aa into sofastack:master Oct 18, 2021
@wangchengming666 wangchengming666 deleted the fix-#1091 branch October 19, 2021 01:46
@EvenLjj EvenLjj added this to the 5.8.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok First-time contributor First-time contributor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants