Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error code-formatter of comment for package-info.java #1273

Closed
jnan806 opened this issue Oct 30, 2022 · 2 comments · Fixed by #1276
Closed

error code-formatter of comment for package-info.java #1273

jnan806 opened this issue Oct 30, 2022 · 2 comments · Fixed by #1276

Comments

@jnan806
Copy link
Contributor

jnan806 commented Oct 30, 2022 •
edited
Loading

Describe the bug

I found that the all comment for package-info.java in this project is error in code-formatter; Should we fix it ?

For example,
In current code, the comment is under the package-name in package-info.java , the tips of comment would not occurred when the pointer is focus on the package.
image

When i move the comment above the package-name in package-info.java, the tips will occur.
image

Expected behavior

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • SOFARPC version:
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@EvenLjj
Copy link
Collaborator

EvenLjj commented Nov 2, 2022

@jnan806 Of course, this is also very important. It will be more friendly to users.

@jnan806
Copy link
Contributor Author

jnan806 commented Nov 2, 2022

Okay, I will optimize it ~

jnan806 added a commit to jnan806/sofa-rpc that referenced this issue Nov 2, 2022
@jnan806
optimize comment of package-info.java. (sofastack#1273)
95fa2e4
jnan806 added a commit to jnan806/sofa-rpc that referenced this issue Nov 2, 2022
@jnan806
optimize comment of package-info.java. (sofastack#1273)
a7d1bd3 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@jnan806 jnan806 mentioned this issue Nov 2, 2022
Merged
jnan806 added a commit to jnan806/sofa-rpc that referenced this issue Nov 2, 2022
@jnan806
optimize comment of package-info.java. (sofastack#1273)
518c008 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
jnan806 added a commit to jnan806/sofa-rpc that referenced this issue Nov 3, 2022
@jnan806
optimize comment of package-info.java. (sofastack#1273)
8b392de 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
EvenLjj pushed a commit that referenced this issue Nov 8, 2022
@jnan806
optimize comment of package-info.java. (#1273) (#1276)
1d0dbe2 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>

Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize comment of package-info.java. (#1273) jnan806/sofa-rpc
2 participants
@EvenLjj @jnan806