-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable other class find all threadpool and logspaces #201
Conversation
WalkthroughThe recent updates to the codebase involve enhancements to logging and thread pool management functionalities. Specifically, new capabilities have been added for retrieving a copy of the log factory map and obtaining a collection of thread pool monitor wrappers. These changes aim to improve the observability and manageability of the application's logging and threading aspects. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
============================================
+ Coverage 35.09% 35.16% +0.07%
Complexity 692 692
============================================
Files 76 76
Lines 5756 5758 +2
Branches 1097 1097
============================================
+ Hits 2020 2025 +5
Misses 3480 3480
+ Partials 256 253 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
pom.xml
is excluded by:!**/*.xml
Files selected for processing (2)
- src/main/java/com/alipay/sofa/common/log/MultiAppLoggerSpaceManager.java (2 hunks)
- src/main/java/com/alipay/sofa/common/thread/ThreadPoolGovernor.java (2 hunks)
Additional comments: 4
src/main/java/com/alipay/sofa/common/thread/ThreadPoolGovernor.java (2)
- 23-24: The import statements for
ArrayList
andCollection
are correctly added to support the new functionality.- 371-373: The implementation of
getAllThreadPoolWrappers
method is correct and effectively returns a collection ofThreadPoolMonitorWrapper
instances. Consider adding a comment explaining that a new collection is returned to prevent external modifications to the internal state.src/main/java/com/alipay/sofa/common/log/MultiAppLoggerSpaceManager.java (2)
- 35-35: The import statement for
HashMap
is correctly added to support the new functionality.- 366-368: The implementation of
getLogFactoryMap
method is correct and effectively returns a copy of theLOG_FACTORY_MAP
. Consider adding a comment explaining that a new map is returned to prevent external modifications to the internal state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit