New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rank undefined issue #98

Merged

milot-mirdita merged 1 commit into soedinglab:master from snjlee58:master

Jan 2, 2025

Collaborator

snjlee58 commented Jan 2, 2025 •

edited

Loading

Cause of error:

There was an issue in the case where there is more than one superkingdoms. In the process of backtracking the list to find the lineage of the second superkingdom, it would produce an undefined object because there superkingdom is the highest rank in the sankey.

Fix:

Added a check for undefined or null.

Note to reviewer:

I only checked that the sankey is drawn and rendered correctly with the taxonomy report file. Needs check to make sure selecting the nodes filters hits correctly.


          fix: rank undefined issue

a303a21

milot-mirdita merged commit 0ee170d into soedinglab:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet