Update backup handle usage mechanism #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sushanthakumar <sushanth.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind enhancement
What this PR does / why we need it:
In current mechanism, kahu volume service uses snapshot handle in volume content status as the handle to keep the mapping between snapshots and corresponding backups. But this snapshot handle creating mechanism can different across different drivers.
So tracing back during restore can not be a common mechanism across different csi drivers
So in new mechanism, kahu volume service will use snapshot content name itself as the handle to map between backups and snapshots
Which issue(s) this PR fixes:
Fixes ##185
Test Report Added?:
kind TESTED
Test Report:
Verify that snapshot name is used as handle in volumebackupcontent (VBC)
Special notes for your reviewer: