removed comments

Signed-off-by: vineela1999 <vineelapachipulusu@gmail.com>

providerframework/metaservice/archiver/manager/manager_test.go

@@ -34,16 +34,16 @@ type ManagerTestSuite struct {
 	typ          archiver.CompressionType
 	fwriter      *mocks.FakeStruct
 	fReader      *mocks.FakeStruct
-	wrirteInvoke func(Writer archiver.Writer) archiver.Writer
-	readInvoke   func(Reader archiver.Reader) archiver.Reader
+	wrirteInvoke func(Writer archiver.Writer) (archiver.Writer, error)
+	readInvoke   func(Reader archiver.Reader) (archiver.Reader, error)
 	archFilePath string
 	fakeType     string
 	archieveYard string
 }
 
 func (suite *ManagerTestSuite) BeforeTest(suiteName, testName string) {
 	suite.fakeType = "faketype"
-	suite.archieveYard = "fakeArchiveYard1"
+	suite.archieveYard = "FakeArchiveYard"
 	suite.archFileName = "FakeArchfileName"
 	suite.typ = archiver.CompressionType("fake")
 	suite.archFilePath = suite.archieveYard + "/" + suite.archFileName
@@ -52,13 +52,11 @@ func (suite *ManagerTestSuite) BeforeTest(suiteName, testName string) {
 		suite.mgr = &archivalManager{
 			archiveYard: suite.archieveYard,
 		}
-		suite.archFileName = "FakeArchfileName"
-
 		err := os.Mkdir(suite.archieveYard, 0777)
 		assert.Nil(suite.T(), err)
 
-		suite.wrirteInvoke = func(Writer archiver.Writer) archiver.Writer {
-			return suite.fwriter
+		suite.wrirteInvoke = func(Writer archiver.Writer) (archiver.Writer, error) {
+			return suite.fwriter, nil
 		}
 		RegisterCompressionWriterPlugins(suite.typ, suite.wrirteInvoke)
 	}
@@ -71,8 +69,8 @@ func (suite *ManagerTestSuite) BeforeTest(suiteName, testName string) {
 		assert.Nil(suite.T(), err)
 
 		suite.fReader = &mocks.FakeStruct{}
-		suite.readInvoke = func(Reader archiver.Reader) archiver.Reader {
-			return suite.fReader
+		suite.readInvoke = func(Reader archiver.Reader) (archiver.Reader, error) {
+			return suite.fReader, nil
 		}
 		RegisterCompressionReaderPlugins(suite.typ, suite.readInvoke)
 	}
@@ -122,13 +120,13 @@ func (suite *ManagerTestSuite) TestGetArchiverSuccess() {
 	//success case
 	_, archFile, err := suite.mgr.GetArchiver(suite.typ, suite.archFileName)
 	assert.Nil(suite.T(), err)
-	assert.Equal(suite.T(), archFile, "fakeArchiveYard1/FakeArchfileName")
+	assert.Equal(suite.T(), archFile, suite.archFilePath)
 }
 
 func (suite *ManagerTestSuite) TestGetArchiverFileAlreadyExists() {
 	//when trying to give already existing file
 	fakefile := suite.archFileName
-	expErr := fmt.Errorf("archival file(fakeArchiveYard1/FakeArchfileName) already exist")
+	expErr := fmt.Errorf("archival file(%s) already exist", suite.archFilePath)
 	_, _, err := suite.mgr.GetArchiver(suite.typ, fakefile)
 	assert.Equal(suite.T(), expErr, err)
 }

providerframework/metaservice/backuprespository/client_test.go

@@ -85,11 +85,11 @@ func (f *FakeMetaBackupClient) Delete(ctx context.Context, in *pb.DeleteRequest,
 }
 
 func (suite *ClientTestSuite) BeforeTest(suiteName, testName string) {
+	suite.filePath = "FakeFile"
 	switch testName {
 	case "TestUploadInvalidPath", "TestDownloadFail":
 		repo, _, _ := NewBackupRepository("/tmp/nfs_test.sock")
 		suite.repo = repo
-		suite.filePath = "fakeFile"
 
 	case "TestUploadValid":
 		client := &FakeMetaBackupClient{}
@@ -101,18 +101,25 @@ func (suite *ClientTestSuite) BeforeTest(suiteName, testName string) {
 		}
 		fakeRespoClient.On("Send", mock.Anything).Return(nil)
 		fakeRespoClient.On("CloseAndRecv", mock.Anything).Return(&pb.Empty{}, nil)
-		filePath := "fakeFile"
-		file, err := os.Create(filePath)
+		file, err := os.Create(suite.filePath)
 		assert.Nil(suite.T(), err)
 		defer file.Close()
 		str := "this is sample data"
 		data := []byte(str)
-		err = os.WriteFile(filePath, data, 0777)
+		err = os.WriteFile(suite.filePath, data, 0777)
+	}
+}
+
+func (suite *ClientTestSuite) AfterTest(suiteName, testName string) {
+	switch testName {
+	case "TestUploadValid":
+		err := os.Remove(suite.filePath)
+		assert.Nil(suite.T(), err)
+
 	}
 }
 
 func (suite *ClientTestSuite) TestUploadInvalidPath() {
-	suite.filePath = "fakeFile"
 	err := suite.repo.Upload(suite.filePath)
 	assert.NotNil(suite.T(), err)
 }

providerframework/metaservice/mocks/mocks.go

@@ -25,23 +25,19 @@ type FakeStruct struct {
 func (f *FakeStruct) Write(p []byte) (n int, err error) {
 	args := f.Called(p)
 	return args.Int(0), args.Error(1)
-	//return 1, nil
 }
 
 func (f *FakeStruct) Close() error {
 	args := f.Called()
 	return args.Error(0)
-	//return nil
 }
 
 func (f *FakeStruct) Read(p []byte) (n int, err error) {
 	args := f.Called(p)
 	return args.Int(0), args.Error(1)
-	//return 0, nil
 }
 
 func (f *FakeStruct) ReadByte() (byte, error) {
 	args := f.Called()
-	return 1, args.Error(1)
-	//return 1, nil
+	return args.Get(0).(byte), args.Error(1)
 }