Skip to content

Commit

Permalink
Update sockjs-protocol-0.3.3.py
Browse files Browse the repository at this point in the history
Are these messages just "string" values and not "array of string" on purpose? All other tests send arrays, not plain string values. And especially considering the name of this particular test "test_reuseSessionId". IMO the test should focus on session reuse, not the payload.
  • Loading branch information
igm committed Nov 20, 2012
1 parent c90ff33 commit c0cc449
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions sockjs-protocol-0.3.3.py
Original file line number Diff line number Diff line change
Expand Up @@ -567,10 +567,10 @@ def test_reuseSessionId(self):
ws2 = websocket.create_connection(ws_url, on_close=on_close)
self.assertEqual(ws2.recv(), u'o')

ws1.send(u'"a"')
ws1.send(u'["a"]')
self.assertEqual(ws1.recv(), u'a["a"]')

ws2.send(u'"b"')
ws2.send(u'["b"]')
self.assertEqual(ws2.recv(), u'a["b"]')

ws1.close()
Expand All @@ -580,7 +580,7 @@ def test_reuseSessionId(self):
# previous connection.
ws1 = websocket.create_connection(ws_url)
self.assertEqual(ws1.recv(), u'o')
ws1.send(u'"a"')
ws1.send(u'["a"]')
self.assertEqual(ws1.recv(), u'a["a"]')
ws1.close()

Expand Down

0 comments on commit c0cc449

Please sign in to comment.